Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scroll down progress bar added #1035

Merged
merged 3 commits into from
Jul 17, 2024
Merged

feat: Scroll down progress bar added #1035

merged 3 commits into from
Jul 17, 2024

Conversation

chaanakyaaM
Copy link
Contributor

Title and Issue number

Title :Scroll down progress bar added

Issue No. : #1030

Code Stack : HTML, CSS , JavaScript

Close #1030

Description

I have added the scroll down progress bar.

Video/Screenshots (mandatory)

scroll.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 0464ab2
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/669504b7d5bfba0007488bde
😎 Deploy Preview https://deploy-preview-1035--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chaanakyaaM chaanakyaaM changed the title Scroll down progress bar added feat: Scroll down progress bar added Jul 9, 2024
apu52
apu52 requested changes Jul 14, 2024
View reviewed changes
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaanakyaaM this PR has merge conflicts .please try to resolve them faster so that I can review the code & will be able to merge it or submit a complete new PR to avoid the merging conflicts

@apu52 apu52 added the help wanted Extra attention is needed label Jul 14, 2024
@chaanakyaaM
Copy link
Contributor Author

Merge conflicts resolved.

apu52
apu52 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaanakyaaM okk

@apu52 apu52 merged commit 169de88 into apu52:main Jul 17, 2024
6 checks passed
@apu52 apu52 added enhancement New feature or request level1 gssoc and removed help wanted Extra attention is needed labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apu52 apu52 apu52 approved these changes

Assignees

@chaanakyaaM chaanakyaaM

Labels
enhancement New feature or request gssoc level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add scroll down progress bar
2 participants
@chaanakyaaM @apu52